Move otlp utilities to otlp package#8326
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8326 +/- ##
=========================================
Coverage 90.86% 90.87%
- Complexity 7985 7987 +2
=========================================
Files 898 899 +1
Lines 24111 24113 +2
Branches 2408 2408
=========================================
+ Hits 21909 21913 +4
+ Misses 1457 1456 -1
+ Partials 745 744 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…y-java into exporter-util-to-otlp
jaydeluca
approved these changes
Apr 24, 2026
psx95
approved these changes
Apr 27, 2026
Closed
Member
Author
|
Take a look @open-telemetry/java-approvers |
…y-java into exporter-util-to-otlp
zeitlinger
approved these changes
May 18, 2026
Member
zeitlinger
left a comment
zeitlinger
left a comment
There was a problem hiding this comment.
Looks good to me. The utility move is scoped well, tests cover the no-sender path explicitly, and I don't see any remaining issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6970
We have a bunch of public classes in internal packages in
opentelemetry-exporter-commonwhich are only used inopentelemetry-exporter-otlp(and the unpublishedopentelemetry-exporter-profiles).Moving these public classes to where they are used reduces shared internal code.